API Review: ProcessId for ProcessFailedEventArgs #5401
Conversation
Add ProcessId property to CoreWebView2ProcessFailedEventArgs4 This API extends ProcessFailedEventArgs to include the process ID of the failed process, enabling applications to: - Correlate process failures with running process data from the ProcessInfo API - Collect process-specific diagnostic information for logging and telemetry - Analyze crash dumps for specific processes - Better track and respond to failures in multi-renderer scenarios The process ID is only available if the process has started and ended unexpectedly. For other failure types, the process ID value will be 0.
There was a problem hiding this comment.
Pull Request Overview
This PR adds a ProcessId property to CoreWebView2ProcessFailedEventArgs to expose the process ID of failed WebView2 processes. This enhancement enables applications to correlate process failures with runtime process information, collect process-specific diagnostics, and better handle failures in multi-renderer scenarios.
Key Changes:
- Added
ICoreWebView2ProcessFailedEventArgs4interface withProcessIdproperty - The process ID returns 0 for failure types where the process never started successfully
- Provides correlation capability with existing ProcessInfo API
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /// analyze crash dumps for that process. The process ID should be | ||
| /// available in all failure kinds e.g. when GPU process hangs, | ||
| /// browser process exits, utility process exits or renderer process hangs. | ||
| /// If the main frame renderer process is gone externally, the process ID | ||
| /// will be set to 0. |
There was a problem hiding this comment.
Inconsistent documentation: The PR description states "The process ID is only available if the process has started and ended unexpectedly. For other failure types, the process ID value will be 0." However, the API documentation in lines 168-172 states "The process ID should be available in all failure kinds e.g. when GPU process hangs, browser process exits, utility process exits or renderer process hangs." These statements contradict each other regarding when the process ID is available.
Co-authored-by: Copilot <[email protected]>
|
@microsoft-github-policy-service agree company="Microsoft" |
Add ProcessId property to CoreWebView2ProcessFailedEventArgs4
This API extends ProcessFailedEventArgs to include the process ID of the failed process, enabling applications to:
The process ID is only available if the process has started and ended unexpectedly. For other failure types, the process ID value will be 0.